[PATCH 12/34] cyclictest: fix off-by-one in clocksel check
From: Tommi Rantala <hidden>
Date: 2017-05-22 08:26:19
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Tommi Rantala <hidden>
Date: 2017-05-22 08:26:19
Subsystem:
the rest · Maintainer:
Linus Torvalds
Fix off-by-one when checking that clocksel is valid index to the array. Also fix a compiler warning: src/cyclictest/cyclictest.c: In function 'process_options': src/cyclictest/cyclictest.c:1828:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (clocksel < 0 || clocksel > ARRAY_SIZE(clocksources)) Signed-off-by: Tommi Rantala <redacted> --- src/cyclictest/cyclictest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index f2747e4..d89cb0f 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c@@ -1823,7 +1823,7 @@ static void process_options (int argc, char *argv[], int max_cpus) if (tracelimit) fileprefix = procfileprefix; - if (clocksel < 0 || clocksel > ARRAY_SIZE(clocksources)) + if (clocksel < 0 || clocksel >= (int)ARRAY_SIZE(clocksources)) error = 1; if (oscope_reduction < 1)
--
2.9.3