Thread (21 messages) 21 messages, 2 authors, 2016-03-03

Re: [PATCH RT 07/17] arm64: replace read_lock to rcu lock in call_step_hook

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2016-03-03 14:12:56
Also in: lkml

On Thu, 3 Mar 2016 09:53:00 +0530
Pratyush Anand [off-list ref] wrote:
quoted
diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
index 636ba8b6240b..f66d668ffce9 100644
--- a/arch/arm64/kernel/debug-monitors.c
+++ b/arch/arm64/kernel/debug-monitors.c
@@ -190,19 +190,22 @@ static void clear_regs_spsr_ss(struct pt_regs *regs)
 /* EL1 Single Step Handler hooks */
 static LIST_HEAD(step_hook);
 DEFINE_RWLOCK(step_hook_lock);
+static DEFINE_RWLOCK(step_hook_lock);  
I think, this got wrong during backporting, no?
Should have been
-DEFINE_RWLOCK(step_hook_lock);
Crap! Yep you are right. I screwed this up. I'll go fix it. Luckily,
that patch ended there. It didn't affect 3.12 or earlier.

Thanks for catching that.

-- Steve
quoted
+static DEFINE_SPINLOCK(step_hook_lock);  
~Pratyush
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help