Re: [PATCH 4/4] tools lib traceevent: Implements '%' operation
From: Arnaldo Carvalho de Melo <hidden>
Date: 2016-02-23 14:38:24
Also in:
lkml
Em Mon, Feb 22, 2016 at 03:23:03PM -0500, Steven Rostedt escreveu:
On Mon, 22 Feb 2016 14:08:22 -0300 Daniel Bristot de Oliveira [off-list ref] wrote:quoted
The operation '%' is not implemented on event-parse.c, causing an error on the parse of events with '%' operation on its printk format. For example, # perf record -e sched:sched_deadline_yield ~/y Warning: [sched:sched_deadline_yield] unknown op '%' .... # perf script Warning: [sched:sched_deadline_yield] unknown op '%' y 1641 [006] 3364.109319: sched:sched_deadline_yield: \ [FAILED TO PARSE] now=3364109314595 \ deadline=3364139295135 runtime=19975597 This patch implements the '%' operation. With this patch, we see the correct output: # perf record -e sched:sched_deadline_yield ~/y No Warning # perf script y 4005 [001] 4623.650978: sched:sched_deadline_yield: \ now=4623.650974050 \ deadline=4623.680957364 remaining_runtime=19979611 Signed-off-by: Daniel Bristot de Oliveira <redacted>Arnaldo, This patch is not dependent on the rest of the series and looks like a good general fix. Can you pull this one into your tree, and please add my: Reviewed-by: Steven Rostedt <redacted>
Done, thanks. - Arnaldo