Thread (25 messages) 25 messages, 7 authors, 2016-03-14

Re: [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow

flat view

From: Josh Cartwright <hidden>
Date: 2016-02-26 19:00:48
Also in: linux-serial

Possibly related (same subject, not in this thread)

On Fri, Feb 26, 2016 at 01:26:27PM -0500, Kuba Kicinski wrote:
On 26 February 2016 11:52:28 GMT-05:00, Josh Cartwright [off-list ref] wrote:
[..]
quoted
Instead, the driver needs to implement it's own oneshot-like
handling at the device-level: in the registered irq handler, capture
triggered interrupt state, squelch/mask, and enqueue the
kthread_work.  In the tail-end of the kthread_work, re-enable
interrupts at the device level.
The problem there being IIRC that i2c doesn't provide async writes so
we can't mask from irq callback. The only option would be
disable_irq/enable_irq, right?
Ah, yes, that is a problem.  If by disable_irq(), you mean
disable_irq_nosync(), then yes, I think that'd work.

  Josh

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help