On Mon, Sep 21, 2015 at 09:52:55PM +0200, John Kacur wrote:

On Mon, 21 Sep 2015, Henrik Austad wrote:

quoted

linker must be able to resolve reference to err_msg_n properly

   rt-migrate-test.c:(.text+0x1ff): undefined reference to `err_msg_n'

Signed-off-by: Henrik Austad <redacted>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index fcf20ce..66de743 100644
--- a/Makefile
+++ b/Makefile

@@ -87,8 +87,8 @@ hwlatdetect:  src/hwlatdetect/hwlatdetect.py
 	chmod +x src/hwlatdetect/hwlatdetect.py
 	ln -s src/hwlatdetect/hwlatdetect.py hwlatdetect
 
-rt-migrate-test: rt-migrate-test.o
-	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS)
+rt-migrate-test: rt-migrate-test.o librttest.a
+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) $(RTTESTLIB)
 
 ptsematest: ptsematest.o librttest.a
 	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) $(RTTESTLIB) $(EXTRA_LIBS)

-- 

Ah, I see, this patch fixes the compile error that the previous patch 
introduces. So, you at least need to reorder them.

I'm accepting this patch for now, but I think some time is necessary to 
review the previous patch.

Yep, I'll see if I can clean it up and make sure I catch all instances of 
warnings etc. It should have been applied *before* the "remove 
warnings"-patch.

Signed-off-by: John Kacur <jkacur@redhat.com>

Thanks though!

-- 
Henrik Austad
TIPBU Eng
Cisco Systems Norway