Re: [PATCH V2 RESEND 1/1] Clocksource: Add sched_clock to Atmel TCB clocksource
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2015-06-11 15:15:34
* Carsten Emde | 2015-06-03 00:08:05 [+0200]:
quoted hunk ↗ jump to hunk
@@ -339,6 +346,10 @@ static int __init tcb_clksrc_init(void)if (ret) goto err_disable_t1; + local_irq_save(flags); + sched_clock_register(sched_clock_get_cycles, 32, divided_rate); + local_irq_restore(flags);
The other sched_clock_register() users don't do this and are invoked via CLOCKSOURCE_OF_DECLARE / clocksource_of_init() and this is probably early enough so the irqs stay off. Since this is not -RT specific at all, do you mind routing it via ARM/ clocksource folks? They also may have an idea what is stopping them from using clocksource_of_init() so you wouldn't have to disable interrupts here.
/* channel 2: periodic and oneshot timer support */ ret = setup_clkevents(tc, clk32k_divisor_idx); if (ret)
Sebastian