[PATCH] cyclictest: remove compatibilty hack for old libnuma, repairs "-a" for isolcpus
From: Henning Schild <hidden>
Date: 2015-05-20 12:58:27
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2015-05-21 · Re: [PATCH] cyclictest: remove compatibilty hack for old libnuma, repairs "-a" for isolcpus · John Kacur <jkacur@redhat.com>
Recent versions of libnuma >=2.0.9 all have numa_parse_cpustring_all(). Not using this function will make the parser fail if isolcpus are used. Signed-off-by: Henning Schild <redacted> --- src/cyclictest/rt_numa.h | 10 ---------- 1 file changed, 10 deletions(-)
diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h
index 06c9420..64516f5 100644
--- a/src/cyclictest/rt_numa.h
+++ b/src/cyclictest/rt_numa.h@@ -92,17 +92,7 @@ static inline unsigned int rt_numa_bitmask_isbitset( const struct bitmask *mask, static inline struct bitmask* rt_numa_parse_cpustring(const char* s, int max_cpus) { -#ifdef HAVE_PARSE_CPUSTRING_ALL /* Currently not defined anywhere. No - autotools build. */ return numa_parse_cpustring_all(s); -#else - /* We really need numa_parse_cpustring_all(), so we can assign threads - * to cores which are part of an isolcpus set, but early 2.x versions of - * libnuma do not have this function. A work around should be to run - * your command with e.g. taskset -c 9-15 <command> - */ - return numa_parse_cpustring((char *)s); -#endif } static inline void rt_bitmask_free(struct bitmask *mask)
--
2.3.6