Thread (3 messages) 3 messages, 2 authors, 2015-02-26

Re: [PATCH -rt] lockdep: selftest: fix warnings due to missing PREEMPT_RT conditionals

From: Xander Huff <hidden>
Date: 2015-01-29 01:17:31
Also in: lkml

On 1/28/2015 1:08 PM, Xander Huff wrote:
From: Josh Cartwright <redacted>

"lockdep: Selftest: Only do hardirq context test for raw spinlock"
disabled the execution of certain tests with PREEMPT_RT_FULL, but did
not prevent the tests from still being defined.  This leads to warnings
like:

   ./linux/lib/locking-selftest.c:574:1: warning: 'irqsafe1_hard_rlock_12' defined but not used [-Wunused-function]
   ./linux/lib/locking-selftest.c:574:1: warning: 'irqsafe1_hard_rlock_21' defined but not used [-Wunused-function]
   ./linux/lib/locking-selftest.c:577:1: warning: 'irqsafe1_hard_wlock_12' defined but not used [-Wunused-function]
   ./linux/lib/locking-selftest.c:577:1: warning: 'irqsafe1_hard_wlock_21' defined but not used [-Wunused-function]
   ./linux/lib/locking-selftest.c:580:1: warning: 'irqsafe1_soft_spin_12' defined but not used [-Wunused-function]
   ...

Fixed by wrapping the test definitions in #ifndef CONFIG_PREEMPT_RT_FULL
conditionals.

Signed-off-by: Josh Cartwright <redacted>
Signed-off-by: Xander Huff <redacted>
Acked-by: Gratian Crisan <redacted>
FYI: To be clearer, this should apply to all stable RT releases 3.4 and later.

-- 
Xander Huff
Staff Software Engineer
National Instruments
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help