Re: [PATCH rt] fix "list_bl.h: make list head locking RT safe" for !SMP && !DEBUG_SPINLOCK
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2013-07-09 07:39:25
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2013-07-09 07:39:25
On 07/09/2013 12:44 AM, Paul Gortmaker wrote:
On 13-07-08 06:26 PM, Uwe Kleine-König wrote:quoted
and so depending on LIST_BL_LOCKMASK being one. But LIST_BL_LOCKMASK is only one if at least on of CONFIG_SMP and CONFIG_DEBUG_SPINLOCK are defined. Without these the value returned by hlist_bl_first has the zeroth bit set which likely results in a crash.The incorrect assumption that I made was that the bit spin locks still set/cleared the bit in the !SMP case. So if we set the bit and the mask is zero, we get the mismatch, giving something like: Acked-by: Paul Gortmaker <redacted> Tested-by: Paul Gortmaker <redacted>
Thanks everyone.
Thanks, Paul.
Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html