Thread (8 messages) 8 messages, 4 authors, 2012-12-21

Re: [ANNOUNCE] 3.6.6-rt17

From: Fernando Lopez-Lezcano <hidden>
Date: 2012-11-16 00:46:32
Also in: lkml

On 11/15/2012 10:11 AM, Thomas Gleixner wrote:
On Wed, 14 Nov 2012, Fernando Lopez-Lezcano wrote:
quoted
On 11/12/2012 01:28 PM, Thomas Gleixner wrote:
quoted
Dear RT Folks,

I'm pleased to announce the 3.6.6-rt17 release. 3.6.6-rt16 is just a
not announced update release to 3.6.6.
Got this:

----
net/nfc/llcp/llcp.c: In function 'nfc_llcp_register_device':
net/nfc/llcp/llcp.c:1185:24: error: expected expression before '{' token
net/nfc/llcp/llcp.c:1186:35: error: expected expression before '{' token
----

when building with CONFIG_NFC / CONFIG_NFS_LLCP (builds fine when those are
not set)
Grrr. Damned ignorants.

Does that fix it for you ?
Yes, thanks! I had to tweak the patch but it does make the whole thing 
compile.
-- Fernando

quoted hunk ↗ jump to hunk
------------>

Subject: nfc: Use proper lock init functions
From: Thomas Gleixner<redacted>
Date: Thu, 15 Nov 2012 19:03:20 +0100

Grmbl. Why insist people on using static initializers if there are
proper init functions? Just because they can?

Signed-off-by: Thomas Gleixner<redacted>
---
  net/nfc/llcp/llcp.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-stable/net/nfc/llcp/llcp.c
===================================================================
--- linux-stable.orig/net/nfc/llcp/llcp.c
+++ linux-stable/net/nfc/llcp/llcp.c
@@ -1182,8 +1182,8 @@ int nfc_llcp_register_device(struct nfc_
  		goto err_rx_wq;
  	}

-	local->sockets.lock = __RW_LOCK_UNLOCKED(local->sockets.lock);
-	local->connecting_sockets.lock = __RW_LOCK_UNLOCKED(local->connecting_sockets.lock);
+	rwlock_init(&local->sockets.lock);
+	rwlock_init(&local->connecting_sockets.lock);

  	nfc_llcp_build_gb(local);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help