Thread (16 messages) 16 messages, 5 authors, 2012-10-24

Re: [PATCH-v2] tty: prevent unnecessary work queue lock checking on flip buffer copy

From: Ivo Sieben <hidden>
Date: 2012-09-25 14:39:56
Also in: linux-serial

Hi,

2012/9/25 Alan Cox [off-list ref]:

then surely the right fix is

        if (tty->low_latency == 0)
                flush_work(&tty->buf.work);
Your are right, that is indeed more straightforward & logical.
But what if a TTY driver uses the tty_schedule_flip() function instead
of tty_flip_buffer_push() and has low_latency set to 1?
In that case the work queue will never be flushed...

Or should drivers that use tty_schedule_flip() function never set the
low_latency flag? (a quick scan indeed shows that all drivers that use
the low_latency flag indeed make use of the tty_flip_buffer_push()
function).

Best regards,
Ivo Sieben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help