Re: [PATCH RT 3/4] mips-remove-smp-reserve-lock.patch

From
David Daney <hidden>
Date
2012-06-07 17:50:54
Also in
lkml
Reply to
Steven Rostedt, 2012-06-07
On 06/07/2012 08:51 AM, Steven Rostedt wrote:
From: Thomas Gleixner<redacted>

Instead of making the lock raw, remove it as it protects nothing.
I don't know how you guys are managing the RT branch, but this seems quite similar to:

a3c8b4faeeccb33dbad6969bc9e50bf409f167e7 (MIPS: Cavium: Remove smp_reserve_lock.)

David Daney

quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Gleixner<redacted>
Cc: <redacted>
Signed-off-by: Steven Rostedt<rostedt@goodmis.org>
---
  arch/mips/cavium-octeon/smp.c |    6 ------
  1 file changed, 6 deletions(-)
diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index efcfff4..86fce15 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -257,8 +257,6 @@ DEFINE_PER_CPU(int, cpu_state);

  extern void fixup_irqs(void);

-static DEFINE_SPINLOCK(smp_reserve_lock);
-
  static int octeon_cpu_disable(void)
  {
  	unsigned int cpu = smp_processor_id();
@@ -266,8 +264,6 @@ static int octeon_cpu_disable(void)
  	if (cpu == 0)
  		return -EBUSY;

-	spin_lock(&smp_reserve_lock);
-
  	cpu_clear(cpu, cpu_online_map);
  	cpu_clear(cpu, cpu_callin_map);
  	local_irq_disable();
@@ -277,8 +273,6 @@ static int octeon_cpu_disable(void)
  	flush_cache_all();
  	local_flush_tlb_all();

-	spin_unlock(&smp_reserve_lock);
-
  	return 0;
  }
  
Thread (10 messages) 10 messages, 2 authors, last reply 2012-06-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help