Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

On Thu, Mar 8, 2012 at 9:34 PM, Steven Rostedt [off-list ref] wrote:

On Thu, 2012-03-08 at 14:22 -0600, Clark Williams wrote:

quoted

On Thu, 08 Mar 2012 15:17:20 -0500
Steven Rostedt [off-list ref] wrote:

quoted

On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:

quoted

When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
defined the following build break occurs.

/home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
/home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
make[2]: *** [block/blk-softirq.o] Error 1
make[1]: *** [block/blk-softirq.o] Error 2
make: *** [sub-make] Error 2

This patch fixes the build error by adding a define to the
!CONFIG_PREEMPT_COUNT section.

Signed-off-by: Clark Williams <redacted>

Why Clark's SOB? Did he write it and send it to you?

I suppose to be technically correct it should have been a Tested-by:

John found it while I was working on it and I tested it for him.

Either a "Reported-by" if you mentioned it to John and he fixed it, or a
"Tested-by" if he fixed it and you tested it. You can have both if that
is true too.

But "Signed-off-by" has supposed legal significance. It means that you
are responsible for this patch. Either you authored it, or it went
through you to get to the git repo (ie. you are the maintainer that took
the patch).

All other tags are FYI only. Only the SOB is required and has real
meaning. Also, you should *never* add a SOB to a patch without the
person explicitly giving it to you.

-- Steve

Good, understood. Please change to

Tested-by: Clark Willilams <redacted>
Signed-off-by: John Kacur <jkacur@redhat.com>

Note that the patch is for 3.2.9-rt17

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html