Re: [PATCH 2/3] rt-tests: Silence unused-but-set warning in rt-migrate-test

On 03/21/2012 09:41 AM, John Kacur wrote:

On Wed, Mar 21, 2012 at 5:36 PM, Darren Hart [off-list ref] wrote:

quoted

On 03/21/2012 09:18 AM, Steven Rostedt wrote:

quoted

On Wed, 2012-03-21 at 15:56 +0100, John Kacur wrote:

quoted

quoted

Yup, shows up on my F16 machine too, with a slightly different gcc version.
gcc --version
gcc (GCC) 4.6.2 20111027 (Red Hat 4.6.2-1)

Egad! This is an old version. It still uses *gasp* logdev!

I have a new version that writes into ftrace, and doesn't use #ifdef,
but instead just looks to see if it is added to the kernel or not.

So no, this patch isn't the fix. The real fix is to upgrade to the new
version of the code.

Of the compiler you mean?

:) Yup, that's what he meant. Of course this is not a realistic option
for many of us. Can you live with the stupid warning for now instead
of cluttering the code with the annotations?

Of course, provided this is indeed a gcc bug. I understand we should use
attributes like this very sparingly and I relunctantly sent the patch
thinking it was reasonable for gcc to miss the usage as it gets rolled
into va_list.

Is this resolved in a later version of gcc? Rostedt you apparently use a
newer compiler, can you try a build?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel