Re: [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL
From: Frank Rowand <hidden>
Date: 2011-09-23 20:16:08
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2011-09-22 · [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL · Frank Rowand <hidden>
On 09/23/11 10:36, Valdis.Kletnieks@vt.edu wrote:
On Thu, 22 Sep 2011 14:05:56 PDT, Frank Rowand said:quoted
Change from V1 to V2: add drivers/tty/serial/8250.cquoted
drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 1 + 1 - 0 ! drivers/tty/serial/mfd.c | 2 1 + 1 - 0 ! drivers/tty/serial/nwpserial.c | 2 1 + 1 - 0 ! drivers/tty/serial/omap-serial.c | 2 1 + 1 - 0 ! drivers/tty/serial/sunhv.c | 4 2 + 2 - 0 ! drivers/tty/serial/sunsab.c | 2 1 + 1 - 0 ! drivers/tty/serial/sunsu.c | 2 1 + 1 - 0 ! drivers/tty/serial/sunzilog.c | 2 1 + 1 - 0 ! drivers/tty/serial/uartlite.c | 2 1 + 1 - 0 ! drivers/tty/serial/xilinx_uartps.c | 2 1 + 1 - 0 !quoted
if (up->port.sysrq) locked = 0; - else if (oops_in_progress) { + else if (oops_in_progress || sysrq_in_progress) { locked = spin_trylock(&up->port.lock); } else spin_lock(&up->port.lock);Is it time to create a helper function for this chunk of code that appears in almost identical form in a dozen drivers?
Thanks for pointing that out. The "if (up->port.sysrq)" in this pattern already handles the case that I was trying to deal with in all of those drivers, except cpm_uart_core.c, so I was able to remove all the other drivers from V3 of the patch. -Frank