Re: [PATCH] rtc-tegra: properly initialize spinlock
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-07-22 22:14:21
Also in:
lkml
On Fri, 22 Jul 2011 10:35:56 +0200 Uwe Kleine-K__nig [off-list ref] wrote:
Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and breaks with PREEMPT_RT_FULL.
Please define "breaks". Lockdep warnings? Deadlocks?
quoted hunk ↗ jump to hunk
diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index 2fc31aa..75259fe 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c@@ -343,7 +343,7 @@ static int __devinit tegra_rtc_probe(struct platform_device *pdev) /* set context info. */ info->pdev = pdev; - info->tegra_rtc_lock = __SPIN_LOCK_UNLOCKED(info->tegra_rtc_lock); + spin_lock_init(&info->tegra_rtc_lock); platform_set_drvdata(pdev, info);-- 1.7.5.4