Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c
From: Russell King - ARM Linux <hidden>
Date: 2009-08-10 22:02:56
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2009-08-16 · Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c · Wim Van Sebroeck <hidden>
- 2009-08-13 · Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c · Kevin Hilman <hidden>
- 2009-08-09 · Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c · Russell King - ARM Linux <hidden>
- 2009-08-09 · [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c · Uwe Kleine-König <hidden>
On Mon, Aug 10, 2009 at 02:04:31PM -0700, Kevin Hilman wrote:
quoted hunk ↗ jump to hunk
@@ -86,6 +88,9 @@ static void wdt_enable(void) { u32 tgcr; u32 timer_margin; + u32 wdt_freq; + + wdt_freq = clk_get_rate(wdt_clk);
Much better - and only a minor nit which doesn't deserve a repost - wdt_freq should probably match the return type of clk_get_rate. IOW unsigned long.