Thread (45 messages) 45 messages, 10 authors, 2007-10-24

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

From: Paul Mackerras <hidden>
Date: 2007-10-18 00:51:58
Also in: linuxppc-dev

Sergei Shtylyov writes:
quoted
Tony started from an earlier patch by John Stultz, not from your
patches.
    Well, that I can believe, yet the clockevents patch has traces of my
former work, and looking at read_persisitent_time() it looks suspiciously 
close to my version too...
There is basically only one reasonably way to do a lot of this stuff.
quoted
The main reason your patches were rejected were that you completely
broke the VDSO and the deterministic time accounting, and made no
    That's just not true!
    They didn't broke vDSO (to be precise it was John's patch that broke it), 
they just removed the vDSO code known to already be broken by -rt patch for 
several months by then.  And they didn't broke determinictic accounting -- 
they just made two things mutually exclusive.  I haven't yet seen how the 
patches that were preferred dealt with it at all.
OK.  My requirement was that the clocksource/clockevent stuff and the
VDSO were both functional.  Your patch didn't meet that requirement.
    Really? IMO, the harware does keep a constant interrupt rate better than 
software.
Well, if you have actual numbers to back that up, show them to us.
I don't believe you would be able to measure any difference, and so I
prefer the simplicity of only implementing the one-shot mode.
quoted
Because you broke important features
    That is *not true*.
    And nobody had interest to fix them for months (quite strange if they're 
so important) while I had neither time nor interest to deal with them anymore 
having written the code that *did work*, and not only for me.
Well, this is the difference between having a hack that works for you,
and having something that can go upstream into mainline.

Anyway, this discussion doesn't seem to be going anywhere.  If there
are changes you want made, or any other specific concrete action you
want anyone to do, say so.  Otherwise stop whinging.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help