Re: [PATCH RFC] Priority boosting for preemptible RCU
From: Andy Whitcroft <hidden>
Date: 2007-08-24 10:10:09
Also in:
lkml
From: Andy Whitcroft <hidden>
Date: 2007-08-24 10:10:09
Also in:
lkml
Andrew Morton wrote:
quoted
+ for_each_possible_cpu(cpu) { + rbdp = per_cpu(rcu_boost_dat, cpu); + for (i = 0; i < RCU_BOOST_ELEMENTS; i++) { + rbdp[i].rbs_mutex = SPIN_LOCK_UNLOCKED;Doesn't this confound lockdep? We're supposed to use spin_lock_init(). Andy, can we have a checkpatch rule for SPIN_LOCK_UNLOCKED please? It's basically always wrong.
ERROR: Use of SPIN_LOCK_UNLOCKED is deprecated: see Documentation/spinlocks.txt #58: FILE: Z17.c:55: + rbdp[i].rbs_mutex = SPIN_LOCK_UNLOCKED; Also picks up the RW_LOCK_UNLOCKED version too. -apw