Re: [PATCH 2.6.21.5-rt17] IPV6: estalished connections are not shown with "cat /proc/net/tcp6"
From: David Miller <davem@davemloft.net>
Date: 2007-08-29 04:56:38
Possibly related (same subject, not in this thread)
- 2007-08-29 · Re: [PATCH 2.6.21.5-rt17] IPV6: estalished connections are not shown with "cat /proc/net/tcp6" · Steven Rostedt <rostedt@goodmis.org>
- 2007-07-09 · Re: [PATCH 2.6.21.5-rt17] IPV6: estalished connections are not shown with "cat /proc/net/tcp6" · Daniel Walker <hidden>
- 2007-06-23 · Re: [PATCH 2.6.21.5-rt17] IPV6: estalished connections are not shown with "cat /proc/net/tcp6" · Steven Rostedt <rostedt@goodmis.org>
- 2007-06-23 · Re: [PATCH 2.6.21.5-rt17] IPV6: estalished connections are not shown with "cat /proc/net/tcp6" · Thomas Gleixner <hidden>
- 2007-06-22 · [PATCH 2.6.21.5-rt17] IPV6: estalished connections are not shown with "cat /proc/net/tcp6" · Masayuki Nakagawa <hidden>
From: Masayuki Nakagawa <redacted> Date: Tue, 28 Aug 2007 18:41:38 -0700
+static inline void __inet_hash_setbit(unsigned long *bitmask,
+ unsigned int index)
+{
+ if (bitmask)
+ set_bit(index, bitmask);
+}
+
+static inline void __inet_hash_clearbit(unsigned long *bitmask,
+ unsigned int index)
+{
+ if (bitmask)
+ clear_bit(index, bitmask);
+}
+A new atomic operation every single socket hashing insert or delete operation is way too much amount of overhead for what should be a trivial problem. Please fix this in another way that does not add new locks or atomics to the socket creation and destruction fast paths, thank you.