On Mon, 2007-07-30 at 10:28 +0530, Ankita Garg wrote:

On Sun, Jul 29, 2007 at 07:45:40PM -0700, Daniel Walker wrote:

quoted

Signed-off-by: Daniel Walker <redacted>

---
 include/linux/rt_lock.h  |    6 ++++--
 include/linux/spinlock.h |    5 +++--
 2 files changed, 7 insertions(+), 4 deletions(-)

Index: linux-2.6.22/include/linux/rt_lock.h
===================================================================

--- linux-2.6.22.orig/include/linux/rt_lock.h
+++ linux-2.6.22/include/linux/rt_lock.h

@@ -128,12 +128,14 @@ struct semaphore name = \
  */
 #define DECLARE_MUTEX_LOCKED COMPAT_DECLARE_MUTEX_LOCKED

-extern void fastcall __sema_init(struct semaphore *sem, int val, char *name, char *file, int line);
+extern void fastcall
+__sema_init(struct semaphore *sem, int val, char *name, char *file, int line);

 #define rt_sema_init(sem, val) \
 		__sema_init(sem, val, #sem, __FILE__, __LINE__)

-extern void fastcall __init_MUTEX(struct semaphore *sem, char *name, char *file, int line);
+extern void fastcall
+__init_MUTEX(struct semaphore *sem, char *name, char *file, int line);
 #define rt_init_MUTEX(sem) \
 		__init_MUTEX(sem, #sem, __FILE__, __LINE__)

Index: linux-2.6.22/include/linux/spinlock.h
===================================================================

--- linux-2.6.22.orig/include/linux/spinlock.h
+++ linux-2.6.22/include/linux/spinlock.h

@@ -126,7 +126,7 @@ extern int __lockfunc generic__raw_read_

 #ifdef CONFIG_DEBUG_SPINLOCK
  extern __lockfunc void _raw_spin_lock(raw_spinlock_t *lock);
-#define _raw_spin_lock_flags(lock, flags) _raw_spin_lock(lock)
+# define _raw_spin_lock_flags(lock, flags) _raw_spin_lock(lock)

Any reason behind including a space here?

Yes . Sometimes a space is added when a define is embedded inside
#ifdefs , example below.

#ifdef CONFIG_DEBUG_SPINLOCK
# define DEBUG_MACRO do_somedebug_here()
#endif

That's usually the method Ingo uses, and it matches the code surrounding
it in this particular patch.

Daniel