Thread (5 messages) 5 messages, 4 authors, 2007-07-09

Re: PI mutex support on ARM

From: Ingo Molnar <hidden>
Date: 2007-07-08 09:58:56
Also in: lkml

* Remy Bohmer [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- linux-2.6.21.orig/include/asm/futex.h	2007-04-26 05:08:32.000000000 +0200
patch format problem: never diff the asm/ files, diff the asm-arm/ 
files.
+	local_irq_save(flags);
+
+	err = get_user(uval, uaddr);
is it safe to do a get_user() with irqs off?
+	if (err)
+	{
+		local_irq_restore(flags);
+		 return -EFAULT;
+	}
(style problems. Use scripts/checkpatch.pl to verify your patches.)
+	local_irq_restore(flags);
is this method of atomic ops SMP-safe?

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help