Re: [PATCH RT] disable preemption on running show all regs.
From: Daniel Walker <hidden>
Date: 2007-06-19 21:00:56
Also in:
lkml
On Tue, 2007-06-19 at 16:17 -0400, Steven Rostedt wrote:
quoted hunk ↗ jump to hunk
The show all regs sysrq uses the nmi function to do it. But this function expects preemption to be off, or funny things happen. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Index: linux-2.6.21-rt9/drivers/char/sysrq.c ===================================================================--- linux-2.6.21-rt9.orig/drivers/char/sysrq.c +++ linux-2.6.21-rt9/drivers/char/sysrq.c@@ -213,7 +213,9 @@ static struct sysrq_key_op sysrq_showreg static void sysrq_handle_showallregs(int key, struct tty_struct *tty) { + preempt_disable(); nmi_show_all_regs(); + preempt_enable(); }
Looks like you have a whitespace issue here.. Should be tabs, not spaces. Daniel