Thread (2 messages) 2 messages, 2 authors, 2007-06-20
STALE6962d

[PATCH RT] Remove double warning print with faulty preempt disable nesting

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2007-06-19 20:24:33
Also in: lkml

On a faulty preempt disable bug we print out a warning but then we go
and call preempt_enable_no_resched, which also can print out a warning.
This is redundant.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.21-rt9/lib/smp_processor_id.c
===================================================================
--- linux-2.6.21-rt9.orig/lib/smp_processor_id.c
+++ linux-2.6.21-rt9/lib/smp_processor_id.c
@@ -47,7 +47,11 @@ unsigned int notrace debug_smp_processor
 	dump_stack();
 
 out_enable:
-	preempt_enable_no_resched();
+	/*
+	 * Don't print message if we enable to zero.
+	 * We arleady printed a warning up above.
+	 */
+	__preempt_enable_no_resched();
 out:
 	return this_cpu;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help