Re: [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Date: 2021-10-13 22:50:38
Also in:
linux-media, linux-staging, lkml
On Wed, Oct 13, 2021 at 12:11:44AM +0200, Rikard Falkeborn wrote:
The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(), which takes a pointer to const v4l2_m2m_ops as argument. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <redacted>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
quoted hunk ↗ jump to hunk
--- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index bf00fe6534a3..28aab5c7fe33 100644 --- a/drivers/staging/media/rkvdec/rkvdec.c +++ b/drivers/staging/media/rkvdec/rkvdec.c@@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv) rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR); } -static struct v4l2_m2m_ops rkvdec_m2m_ops = { +static const struct v4l2_m2m_ops rkvdec_m2m_ops = { .device_run = rkvdec_device_run, };-- 2.33.0
_______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip