Re: Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify
From: jay.xu@rock-chips.com <hidden>
Date: 2021-08-18 02:25:05
Hi Mark -------------- jay.xu@rock-chips.com
Hi Mark -------------- jay.xu@rock-chips.comquoted
On Tue, Aug 17, 2021 at 11:38:48AM +0800, Jianqun Xu wrote:quoted
+ } else if (event & REGULATOR_EVENT_ENABLE) { + uV = regulator_get_voltage(supply->reg); } else {I am very surprised this doesn't cause locking issues given that we might call notifiers with the regulator API's locks held. Have you tested this with lockdep on?Thanks for your reply, there really has locking issue, our test team fail to find out it but get a pass result. So, if the voltage cannot get here by driver, can the notify pass it, like pre-version patch?
I think it's possilbe to store the voltage in driver side, and do the io-domain config after EVENT_ENABLE notify witout voltage, I will push it to io-domain maintainer to review, can I add yours' review in that patch ? _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip