Thread (2 messages) 2 messages, 2 authors, 2016-12-20

Re: [PATCH -next] phy: rockchip-typec: fix non static symbol warnings

From: Vivek Gautam <hidden>
Date: 2016-12-20 08:28:04
Also in: linux-arm-kernel, lkml

On Wed, Sep 21, 2016 at 8:35 PM, Wei Yongjun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Wei Yongjun <redacted>

Fixes the following sparse warnings:

drivers/phy/phy-rockchip-typec.c:295:16: warning:
 symbol 'usb3_pll_cfg' was not declared. Should it be static?
drivers/phy/phy-rockchip-typec.c:312:16: warning:
 symbol 'dp_pll_cfg' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/phy/phy-rockchip-typec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c
index 7cfb0f8..555604c 100644
--- a/drivers/phy/phy-rockchip-typec.c
+++ b/drivers/phy/phy-rockchip-typec.c
@@ -292,7 +292,7 @@ struct phy_reg {
        u32 addr;
 };

-struct phy_reg usb3_pll_cfg[] = {
+static struct phy_reg usb3_pll_cfg[] = {
const as well ?
quoted hunk ↗ jump to hunk
        { 0xf0,         CMN_PLL0_VCOCAL_INIT },
        { 0x18,         CMN_PLL0_VCOCAL_ITER },
        { 0xd0,         CMN_PLL0_INTDIV },
@@ -309,7 +309,7 @@ struct phy_reg usb3_pll_cfg[] = {
        { 0x8,          CMN_DIAG_PLL0_LF_PROG },
 };

-struct phy_reg dp_pll_cfg[] = {
+static struct phy_reg dp_pll_cfg[] = {
const ?
[..]


Thanks
Vivek

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help