Thread (9 messages) 9 messages, 3 authors, 2016-08-23

Re: [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

From: Sergei Shtylyov <hidden>
Date: 2016-08-21 11:06:46
Also in: linux-devicetree, lkml

Possibly related (same subject, not in this thread)

Hello.

On 8/21/2016 10:56 AM, Randy Li wrote:
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288
has a hardware errata that causes everything to get confused when we get
a remote wakeup.  We'll use the reset that's in the CRU to reset the
port when it's in a bad state.

Note that we add the reset to both dwc2 controllers even though only one
has the errata in case we find some other use for this reset that's
unrelated to the current hardware errata.  Only the host port gets the
quirk property, though.

This patch came from Doug Anderson [off-list ref] originally.
    Was it signed off by him? Don't you need to keep his authorship via th 
"From:" tag?
quoted hunk ↗ jump to hunk
Signed-off-by: Randy Li <redacted>
---
 arch/arm/boot/dts/rk3288.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 48ca4e4..646f49d 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
[...]
quoted hunk ↗ jump to hunk
@@ -871,6 +873,9 @@
 				clocks = <&cru SCLK_OTGPHY2>;
 				clock-names = "phyclk";
 				#clock-cells = <0>;
+				resets = <&cru SRST_USBHOST1_PHY>;
+				reset-names = "phy-reset";
+
    Don't need empty line here.
 			};
 		};
 	};
MBR , Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help