Thread (4 messages) 4 messages, 3 authors, 2016-08-17

Re: [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency

From: Guenter Roeck <hidden>
Date: 2016-08-16 17:19:07
Also in: linux-devicetree, lkml

On Tue, Aug 16, 2016 at 02:02:00PM +0800, Frank Wang wrote:
quoted hunk ↗ jump to hunk
On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2
driver fails to build:

drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw'
has incomplete type
   struct clk_hw clk480m_hw;

In file included from include/linux/clk.h:16:0
                 from drivers/phy/phy-rockchip-inno-usb2.c:17:
include/linux/kernel.h:831:48: error: initialization from incompatible
pointer type [-Werror=incompatible-pointer-types]
   const typeof( ((type *)0)->member ) *__mptr = (ptr); \

  ... ...

Signed-off-by: Frank Wang <redacted>
---
 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index f9bf981..c6d57e5 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB
 config PHY_ROCKCHIP_INNO_USB2
 	tristate "Rockchip INNO USB2PHY Driver"
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
+	depends on COMMON_CLK
Wonder what is preferred here. I find 33 "select COMMON_CLK" and
18 "depends on COMMON_CLK".

Either case

Reviewed-by: Guenter Roeck <redacted>

 	select GENERIC_PHY
 	help
 	  Support for Rockchip USB2.0 PHY with Innosilicon IP block.
-- 
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help