On Tue, 2021-08-03 at 21:22 -0700, Palmer Dabbelt wrote:

On Mon, 05 Jul 2021 16:25:21 PDT (-0700), edwin@etorok.net wrote:

quoted

For libdw-based callgraph sampling to work we need to sample
registers.

Tested on HiFive Unmatched with a trunk version of OCaml:

These generally LGTM, but I don't have patch #2.

PATCH 2/4 is here:
https://lore.kernel.org/linux-riscv/20210705232524.4024832-3-edwin@etorok.net/ (local)
https://patchwork.kernel.org/project/linux-riscv/patch/20210705232524.4024832-3-edwin@etorok.net/

  Sometimes that means 
they're just not targeted at the RISC-V tree, which is fine with me but
I'm happy to take some time to look closer and take them if that's what
you're looking for.
A cover letter can be a good bet, to describe this sort of stuff.

Thanks for taking a look, I'll try to ensure that RISC-V maintainers
are CC-ed on the entire series in the future (I used
scripts/get_maintainer.pl which might've been too selective).

All patches should be on the RISC-V mailing list though, cover letter
included:
https://lore.kernel.org/linux-riscv/20210705232524.4024832-1-edwin@etorok.net/T/#t (local)
https://patchwork.kernel.org/project/linux-riscv/list/?series=511107

PATCH 2/4 is patching tools/perf/check-headers.sh, so although
technically outside of the RISC-V specific tree it actually adds one
line to include the riscv headers, so if you could take all 4 patches
into your tree that'd be great.

Thanks,
--Edwin


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv