Re: [PATCH net v3 3/3] net: stmmac: document oversized AF_XDP frame handling

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-08-24 18:14:45
Also in
bpf, intel-wired-lan, linux-arm-kernel, lkml, netdev
Reply to
Stanislav Fomichev, 2026-08-21
On Fri, 21 Aug 2026 10:28:47 -0700 Stanislav Fomichev wrote:
quoted
quoted
I do agree that a better idea is to probably do these checks during control
paths, but it's a bit more involved (and not sure if it's possible? if we
have a bunch of xsk sockets and we change that max_sdu, do we go over all
sockets on the system somehow?). My main motivation with this patch was
to make our LLM reviewers less chatty about preexisting issues.  
I hear you, however I feel like we do not know this driver too much and
probably we don't have a HW to test out such changes, so maybe let us try
to fix existing behavior?  
Let's definitely fix it properly if you have better ideas. But since we
don't have HW, I'm not super confident doing anything sophisticated
myself :-D
Let me take the first 2 patches and leave the stmmac for later.
I don't think anyone involved care particularly deeply here.

Maxime said he bought a bunch of relevant HW. If we finally wrap 
the AF_XDP tests into driver runtime he should be able to help us...
Thread (16 messages) 16 messages, 7 authors, last reply 2026-08-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help