Thread (3 messages) 3 messages, 3 authors, 2021-12-15

RE: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

From: Marciniszyn, Mike <hidden>
Date: 2021-12-08 18:07:51
Also in: lkml

quoted hunk ↗ jump to hunk
Subject: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by: José Expósito <redacted>
---
 drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c
b/drivers/infiniband/hw/qib/qib_user_sdma.c
index ac11943a5ddb..bf2f30d67949 100644
--- a/drivers/infiniband/hw/qib/qib_user_sdma.c
+++ b/drivers/infiniband/hw/qib/qib_user_sdma.c
@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct
qib_devdata *dd,
 					       &addrlimit) ||
 			    addrlimit > type_max(typeof(pkt->addrlimit))) {
 				ret = -EINVAL;
-				goto free_pbc;
+				goto free_pkt;
 			}
 			pkt->addrlimit = addrlimit;

--
Thanks for catching my mistake!

Mike

Acked-by: Mike Marciniszyn <redacted>
Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"): 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help