[PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by: José Expósito <redacted>
---
 drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c b/drivers/infiniband/hw/qib/qib_user_sdma.c
index ac11943a5ddb..bf2f30d67949 100644
--- a/drivers/infiniband/hw/qib/qib_user_sdma.c
+++ b/drivers/infiniband/hw/qib/qib_user_sdma.c

@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd,
 					       &addrlimit) ||
 			    addrlimit > type_max(typeof(pkt->addrlimit))) {
 				ret = -EINVAL;
-				goto free_pbc;
+				goto free_pkt;
 			}
 			pkt->addrlimit = addrlimit;
 

-- 
2.25.1

Thanks for catching my mistake!

Mike

Acked-by: Mike Marciniszyn <redacted>
Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"): 

On Wed, Dec 08, 2021 at 06:52:38PM +0100, José Expósito wrote:

Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by: José Expósito <redacted>
Acked-by: Mike Marciniszyn <redacted>
---
 drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc.

I wrote a commit message and added the missing fixes line, please take
care in future.

Jason