在 2021/12/6 22:27, Haakon Bugge 写道:

quoted

On 7 Dec 2021, at 07:46, yanjun.zhu@linux.dev wrote:

From: Zhu Yanjun <redacted>

The struct member variable create_flags are assigned twice.

may be "... is assigned twice." ?

My bad. Thanks.

Zhu Yanjun

quoted

Remove the unnecessary assignment.

Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
Signed-off-by: Zhu Yanjun <redacted>

LGTM, so

Reviewed-by: Håkon Bugge <redacted>



Thxs, Håkon

quoted

---
drivers/infiniband/core/uverbs_cmd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index d1345d76d9b1..6b6393176b3c 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c

@@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,

	attr.sq_sig_type   = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
					      IB_SIGNAL_REQ_WR;
	attr.qp_type       = cmd->qp_type;
-	attr.create_flags  = 0;

	attr.cap.max_send_wr     = cmd->max_send_wr;
	attr.cap.max_recv_wr     = cmd->max_recv_wr;
-- 
2.27.0