Re: [PATCH v2 3/5] RDMA/rxe: Change the is_user member of struct rxe_cq to bool
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-09-14 18:33:59
On Thu, Sep 02, 2021 at 04:46:38PM +0800, Xiao Yang wrote:
quoted hunk ↗ jump to hunk
Make all is_user members of struct rxe_sq/rxe_cq/rxe_srq/rxe_cq has the same type. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> drivers/infiniband/sw/rxe/rxe_cq.c | 3 +-- drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/infiniband/sw/rxe/rxe_cq.c b/drivers/infiniband/sw/rxe/rxe_cq.c index aef288f164fd..fd655e41d621 100644 +++ b/drivers/infiniband/sw/rxe/rxe_cq.c@@ -81,8 +81,7 @@ int rxe_cq_from_init(struct rxe_dev *rxe, struct rxe_cq *cq, int cqe, return err; } - if (uresp) - cq->is_user = 1; + cq->is_user = uresp ? true : false;
When you resend this series we don't need any of the ternary expressions, when things implicitly cast to bool they are converted to 1/0 using the same logic as any other boolean expression. So just write cq->is_user = uresp; Jason