Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c

On 9/22/21 23:45, Leon Romanovsky wrote:

Isn't kptr_restrict sysctl is for that?

Hi Leon,

After I sent my email I discovered the following commit: 5ead723a20e0
("lib/vsprintf: no_hash_pointers prints all addresses as unhashed"; v5.12).
I think that commit does what we need?

Thanks,

Bart.


commit 5ead723a20e0447bc7db33dc3070b420e5f80aa6
Author: Timur Tabi [off-list ref]
Date:   Sun Feb 14 10:13:48 2021 -0600

     lib/vsprintf: no_hash_pointers prints all addresses as unhashed

     If the no_hash_pointers command line parameter is set, then
     printk("%p") will print pointers as unhashed, which is useful for
     debugging purposes.  This change applies to any function that uses
     vsprintf, such as print_hex_dump() and seq_buf_printf().

     A large warning message is displayed if this option is enabled.
     Unhashed pointers expose kernel addresses, which can be a security
     risk.

     Also update test_printf to skip the hashed pointer tests if the
     command-line option is set.

     Signed-off-by: Timur Tabi [off-list ref]
     Acked-by: Petr Mladek [off-list ref]
     Acked-by: Randy Dunlap [off-list ref]
     Acked-by: Sergey Senozhatsky [off-list ref]
     Acked-by: Vlastimil Babka [off-list ref]
     Acked-by: Marco Elver [off-list ref]
     Signed-off-by: Petr Mladek [off-list ref]
     Link: https://lore.kernel.org/r/20210214161348.369023-4-timur@kernel.org (local)