Thread (2 messages) 2 messages, 2 authors, 2021-08-26

[PATCH v2] Fix one error in mthca_alloc

flat view
STALE1873d

From: kangning <hidden>
Date: 2021-08-26 14:28:52
Subsystem: infiniband subsystem, the rest · Maintainers: Jason Gunthorpe, Leon Romanovsky, Linus Torvalds

drivers/infiniband/hw/mthca/mthca_allocator.c: alloc->last left unchanged in mthca_alloc, which
has impact on performance of function find_next_zero_bit in mthca_alloc. And the parenthesis and
braces are removed in this version.

Signed-off-by: kangning <redacted>
---
 Thanks for your review, and the parenthesis and braces have been removed in this version.

 drivers/infiniband/hw/mthca/mthca_allocator.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mthca/mthca_allocator.c b/drivers/infiniband/hw/mthca/mthca_allocator.c
index e81bb0fcd08e..1141695093e7 100644
--- a/drivers/infiniband/hw/mthca/mthca_allocator.c
+++ b/drivers/infiniband/hw/mthca/mthca_allocator.c
@@ -51,10 +51,9 @@ u32 mthca_alloc(struct mthca_alloc *alloc)
 	}
 
 	if (obj < alloc->max) {
-		alloc->last = (obj + 1);
-		if (alloc->last == alloc->max) {
+		alloc->last = obj + 1;
+		if (alloc->last == alloc->max)
 			alloc->last = 0;
-		}
 		set_bit(obj, alloc->table);
 		obj |= alloc->top;
 	} else
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help