Re: [PATCHv2 for-rc 0/6] Bugfixes for send queue overflow by heartbeat
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-07-15 17:41:40
On Mon, Jul 12, 2021 at 08:07:44AM +0200, Jack Wang wrote:
Hi Jason, hi Doug,
Please consider to include following changes to upstream.
This patchset fix a regression since b38041d50add ("RDMA/rtrs: Do not signal for heatbeat").
In commit b38041d50add, the signal flag is droped to fix the send queue full
logic, but introduced a worse bug the send queue overflow on both clt and srv
by heartbeat, sorry.
The patchset is orgnized as:
- patch1 debug patch.
- patch2 preparation.
- patch3 signal both IO and heartbeat.
- patch4 cleanup.
- patch5 cleanup
- patch6 move sq_wr_avail to account send queue full correctly.
The patches are created base v5.14-rc1.
Since v1:
* rebased to latest v5.14-rc1, target rc instread of for-next.
v1: https://lore.kernel.org/linux-rdma/20210629065321.12600-1-jinpu.wang@ionos.com/T/#t (local)
Jack Wang (6):
RDMA/rtrs: Add error messages for failed operations.
RDMA/rtrs: move wr_cnt from rtrs_srv_con to rtrs_con
RDMA/rtrs: Enable the same selective signal for heartbeat and IO
RDMA/rtrs: Make rtrs_post_rdma_write_imm_empty static
RDMA/rtrs: Remove unused flags parameter
RDMA/rtrs: Move sq_wr_avail to rtrs_conApplied to for-next, thanks Jason