Thread (7 messages) 7 messages, 3 authors, 2021-07-14

Re: [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup

From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-07-12 17:42:18

On Tue, Jul 06, 2021 at 01:23:45PM -0400, Dennis Dalessandro wrote:
From: Mike Marciniszyn <redacted>

There is no counter for dmawait in AIP, which hampers debugging
performance issues.

Add the counter increment when the txq is queued.

Fixes: d99dc602e2a5 ("IB/hfi1: Add functions to transmit datagram ipoib packets")
Fixes: c4cf5688ea69 ("IB/hfi1: Indicate DMA wait when txq is queued for wakeup")
Neither of these fixes lines are correct, please resend it with
correct fixes lines.

This commit message is not quite good enough to justfy adding a
counter increment to rc, can you explain how this is an existing
counter and it is a bug that this single case was not incremented?

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help