Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void
From: Leon Romanovsky <leon@kernel.org>
Date: 2021-07-18 09:27:22
Also in:
netdev
From: Leon Romanovsky <leon@kernel.org>
Date: 2021-07-18 09:27:22
Also in:
netdev
On Wed, Jul 14, 2021 at 05:23:33PM +0800, Zhu Yanjun wrote:
On Wed, Jul 14, 2021 at 5:15 PM Leon Romanovsky [off-list ref] wrote:quoted
On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@linux.dev wrote:quoted
From: Zhu Yanjun <redacted> The function irdma_sc_repost_aeq_entries always returns zero. So the returned type is changed to void. Signed-off-by: Zhu Yanjun <redacted> --- drivers/infiniband/hw/irdma/ctrl.c | 4 +--- drivers/infiniband/hw/irdma/type.h | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-)<...>quoted
-enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev, - u32 count);I clearly remember that Jakub asked for more than once to remo remove custom ice/irdma error codes. Did it happen? Can we get rid from them in RDMA too?No. This is not related with custom ice/irdma error codes.
I'm not talking about your specific change, but pointed to the fact that custom error codes are not cleaned despite multiple requests. Thanks