Thread (2 messages) 2 messages, 2 authors, 2021-06-24

Re: [PATCH][next][V2] RDMA/bnxt_re: Fix uninitialized struct bit field rsvd1

From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-06-24 12:30:02
Also in: kernel-janitors, lkml

On Wed, Jun 23, 2021 at 07:24:37PM +0100, Colin King wrote:
From: Colin Ian King <redacted>

The bit field rsvd1 in resp is not being initialized and garbage data
is being copied from the stack back to userspace via the ib_copy_to_udata
call. Fix this by setting the entire struct resp to zero; this will ensure
that further new bit fields in the future will be zero'd too.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 879740517dab ("RDMA/bnxt_re: Update ABI to pass wqe-mode to user space")
Signed-off-by: Colin Ian King <redacted>
---

V2: set entire struct resp to zero rather than the new field. Thanks to
    Jason Gunthorpe for suggesting this improved fix.

---
 drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks

I amended it to remove the now redundant  = 0's.

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help