Thread (21 messages) 21 messages, 6 authors, 2021-04-13
STALE1897d REVIEWED: 1 (0M)

[PATCH for-rc 1/4] IB/hfi1: Call xa_destroy before freeing dummy_netdev

From: dennis.dalessandro@cornelisnetworks.com
Date: 2021-03-29 13:50:53
Also in: stable
Subsystem: infiniband subsystem, the rest · Maintainers: Jason Gunthorpe, Leon Romanovsky, Linus Torvalds

From: Kaike Wan <redacted>

Before the dummy_netdev is freeed, xa_destroy() should be called to
free any internal objects to avoid potential memory leak.

Fixes: 06bde82c72d5 ("IB/hfi1: Add rx functions for dummy netdev")
Cc: <redacted>
Reviewed-by: Mike Marciniszyn <redacted>
Signed-off-by: Kaike Wan <redacted>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
---
 drivers/infiniband/hw/hfi1/netdev_rx.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
index 2c8bc02..cec02e8 100644
--- a/drivers/infiniband/hw/hfi1/netdev_rx.c
+++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
@@ -372,7 +372,11 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd)
 void hfi1_netdev_free(struct hfi1_devdata *dd)
 {
 	if (dd->dummy_netdev) {
+		struct hfi1_netdev_priv *priv =
+			hfi1_netdev_priv(dd->dummy_netdev);
+
 		dd_dev_info(dd, "hfi1 netdev freed\n");
+		xa_destroy(&priv->dev_tbl);
 		kfree(dd->dummy_netdev);
 		dd->dummy_netdev = NULL;
 	}
-- 
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help