Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
From: Leon Romanovsky <leon@kernel.org>
Date: 2021-02-21 06:49:21
Also in:
lkml
On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote:
commit 6e61907779ba99af785f5b2397a84077c289888a
Author: Julian Braha [off-list ref]
Date: Fri Feb 19 18:20:57 2021 -0500
drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
When RDMA_RXE is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_CRC32
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]
This is because RDMA_RXE selects CRYPTO_CRC32,
without depending on or selecting CRYPTO, despite that config option
being subordinate to CRYPTO.
Signed-off-by: Julian Braha [off-list ref]Please use git sent-email to send patches and please fix crypto Kconfig to enable CRYPTO if CRYPTO_* selected. It is a little bit awkward to request all users of CRYPTO_* to request select CRYPTO too. Thanks
quoted hunk ↗ jump to hunk
diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig index 452149066792..06b8dc5093f7 100644 --- a/drivers/infiniband/sw/rxe/Kconfig +++ b/drivers/infiniband/sw/rxe/Kconfig@@ -4,6 +4,7 @@ config RDMA_RXE depends on INET && PCI && INFINIBAND depends on INFINIBAND_VIRT_DMA select NET_UDP_TUNNEL + select CRYPTO select CRYPTO_CRC32 help This driver implements the InfiniBand RDMA transport over