Re: [PATCH v3] RDMA/siw: Fix handling of zero-sized Read and Receive Queues.
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-01-07 19:39:22
Also in:
linux-nvme
On Wed, Dec 16, 2020 at 12:00:00PM +0100, Bernard Metzler wrote:
quoted hunk ↗ jump to hunk
@@ -933,6 +937,7 @@ int siw_activate_tx(struct siw_qp *qp) goto out; } +no_irq: sqe = sq_get_next(qp); if (sqe) {
Can you please arrange this without the spaghetti goto's? goto is ok for error unwind at the tail of the function, but should not be used willy nilly. Move some of this into functions, use normal if statements, etc. Jason