Re: [PATCH V2] RDMA: usnic: Fix misuse of sysfs_emit_at
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-01-20 00:35:24
Also in:
lkml
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-01-20 00:35:24
Also in:
lkml
On Fri, Jan 15, 2021 at 04:36:50PM -0800, Joe Perches wrote:
In commit e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show
uses to sysfs_emit") I mistakenly used len = sysfs_emit_at to overwrite
the last trailing space of potentially multiple entry output.
Instead use a more common style by removing the trailing space from the
output formats and adding a prefixing space to the contination formats and
converting the final terminating output newline from the defective
len = sysfs_emit_at(buf, len, "\n");
to the now appropriate and typical
len += sysfs_emit_at(buf, len, "\n");
Fixes: e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to sysfs_emit")
Reported-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)Applied to for-rc, thanks Jason