[PATCH] infiniband: remove unnecessary fallthrough usage
From: Cengiz Can <hidden>
Date: 2020-08-31 15:31:36
Also in:
lkml
Subsystem:
infiniband subsystem, the rest · Maintainers:
Jason Gunthorpe, Leon Romanovsky, Linus Torvalds
Since /* fallthrough */ comments are deprecated[1], they are being replaced by new 'fallthrough' pseudo-keyword. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\ highlight=fallthrough#implicit-switch-case-fall-through This sometimes leads to unreachable code warnings by static analyzers, particularly in this case, Coverity Scanner. (CID 1466512) Remove unnecessary 'fallthrough' keywords to prevent dead code warnings. Signed-off-by: Cengiz Can <redacted> --- drivers/infiniband/hw/qib/qib_mad.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index e7789e724f56..f972e559a8a7 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c@@ -2322,7 +2322,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags, ret = cc_get_congestion_control_table(ccp, ibdev, port); goto bail; - fallthrough; default: ccp->status |= IB_SMP_UNSUP_METH_ATTR; ret = reply((struct ib_smp *) ccp);
@@ -2339,7 +2338,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags, ret = cc_set_congestion_control_table(ccp, ibdev, port); goto bail; - fallthrough; default: ccp->status |= IB_SMP_UNSUP_METH_ATTR; ret = reply((struct ib_smp *) ccp);
--
2.28.0