Re: [PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(), FOLL_PIN

From
Ira Weiny <hidden>
Date
2019-08-23 00:24:54
Also in
linux-fsdevel, linux-mm, lkml
Reply to
John Hubbard, 2019-08-21
On Tue, Aug 20, 2019 at 09:07:24PM -0700, John Hubbard wrote:
Hi Ira,

This is for your tree. I'm dropping the RFC because this aspect is
starting to firm up pretty well.

I've moved FOLL_PIN inside the vaddr_pin_*() routines, and moved
FOLL_LONGTERM outside, based on our recent discussions. This is
documented pretty well within the patches.

Note that there are a lot of references in comments and commit
logs, to vaddr_pin_pages(). We'll want to catch all of those if
we rename that. I am pushing pretty hard to rename it to
vaddr_pin_user_pages().

v1 of this may be found here:
https://lore.kernel.org/r/20190812015044.26176-1-jhubbard@nvidia.com (local)
I am really sorry about this...

I think it is fine to pull these in...  There are some nits which are wrong but
I think with the XDP complication and Daves' objection I think the vaddr_pin
information is going to need reworking.  So the documentation there is probably
wrong.  But until we know what it is going to be we should just take this.

Do you have a branch with this on it?

The patches don't seem to apply.  Looks like they got corrupted somewhere...

:-/

Thanks,
Ira
John Hubbard (3):
  For Ira: tiny formatting tweak to kerneldoc
  mm/gup: introduce FOLL_PIN flag for get_user_pages()
  mm/gup: introduce vaddr_pin_pages_remote(), and invoke it

 drivers/infiniband/core/umem.c |  1 +
 include/linux/mm.h             | 61 ++++++++++++++++++++++++++++++----
 mm/gup.c                       | 40 ++++++++++++++++++++--
 mm/process_vm_access.c         | 23 +++++++------
 4 files changed, 106 insertions(+), 19 deletions(-)

-- 
2.22.1
Thread (6 messages) 6 messages, 2 authors, last reply 2019-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help