Re: [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields

From
Christopher Lameter <hidden>
Date
2018-07-03 00:08:18
Also in
linux-fsdevel, linux-mm, lkml
Reply to
John Hubbard, 2018-07-02
On Mon, 2 Jul 2018, John Hubbard wrote:
quoted
These two are just wrong. You cannot make any page reference for
PageDmaPinned() account against a pin count. First, it is just conceptually
wrong as these references need not be long term pins, second, you can
easily race like:

Pinner				Random process
				get_page(page)
pin_page_for_dma()
				put_page(page)
				 -> oops, page gets unpinned too early
I'll drop this approach, without mentioning any of the locking that is hiding in
there, since that was probably breaking other rules anyway. :) Thanks for your
patience in reviewing this.
Mayb the following would work:

If you establish a reference to a page then increase the page count. If
the reference is a dma pin action also then increase the pinned count.

That way you know how many of the references to the page are dma
pins and you can correctly manage the state of the page if the dma pins go
away.
Thread (30 messages) 30 messages, 5 authors, last reply 2018-07-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help