RE: [PATCH rdma-core] iwpmd: fix double mutex unlock

Subject: Re: [PATCH rdma-core] iwpmd: fix double mutex unlock

On Wed, 2018-01-31 at 10:04 -0600, Steve Wise wrote:

quoted

quoted

quoted

pthread_mutex_unlock() is used twice and this patch fixes it.

Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
Signed-off-by: Potnuri Bharat Teja <redacted>
---
 iwpmd/iwarp_pm_helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
index bebc151f329b..b8c230189d50 100644
--- a/iwpmd/iwarp_pm_helper.c
+++ b/iwpmd/iwarp_pm_helper.c

@@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg

*send_msg)

 	pthread_mutex_lock(&pending_msg_mutex);
 	list_add(&pending_messages, &pending_msg->entry);
- 	pthread_mutex_unlock(&pending_msg_mutex);
 	pthread_mutex_unlock(&pending_msg_mutex);
 	/* signal the thread that a new message has been posted */
 	pthread_cond_signal(&cond_pending_msg);

Good catch.

Reviewed-by: Steve Wise <redacted>

And this definitely needs to flow to stable.

Applied to master branch, thanks.

Thanks Doug.  Do I need to do some process magic to get it into stable and spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?  

Steve.



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html