Re: [PATCH v8 04/14] xfs: prepare xfs_break_layouts() for reuse with MAP_DIRECT
From: Dave Chinner <david@fromorbit.com>
Date: 2017-10-11 00:46:31
Also in:
linux-api, linux-fsdevel, linux-iommu, linux-mm, linux-xfs, nvdimm
On Tue, Oct 10, 2017 at 07:49:17AM -0700, Dan Williams wrote:
Move xfs_break_layouts() to its own compilation unit so that it can be used for both pnfs layouts and MAP_DIRECT mappings.
.....
quoted hunk ↗ jump to hunk
diff --git a/fs/xfs/xfs_pnfs.h b/fs/xfs/xfs_pnfs.h index b587cb99b2b7..4135b2482697 100644 --- a/fs/xfs/xfs_pnfs.h +++ b/fs/xfs/xfs_pnfs.h@@ -1,19 +1,13 @@ #ifndef _XFS_PNFS_H #define _XFS_PNFS_H 1 +#include "xfs_layout.h" +
I missed this the first time through - we try not to put includes in header files, and instead make sure each C file has all the includes they require. Can you move this to all the C files that need layouts and remove the include of the xfs_pnfs.h include from them? Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>